Skip to content

Fix tags serialization bug#1939

Merged
MaggieKimani1 merged 5 commits intovnextfrom
mk/fix-tags-serialization
Dec 17, 2024
Merged

Fix tags serialization bug#1939
MaggieKimani1 merged 5 commits intovnextfrom
mk/fix-tags-serialization

Conversation

@MaggieKimani1
Copy link
Contributor

Fixes #1922

@MaggieKimani1 MaggieKimani1 marked this pull request as ready for review November 20, 2024 09:48
Name = tag?.Name ?? Name;
Description = tag?.Description ?? Description;
ExternalDocs = tag?.ExternalDocs != null ? new(tag?.ExternalDocs) : null;
ExternalDocs = tag?.ExternalDocs != null ? new(tag.ExternalDocs) : null;

Check warning

Code scanning / CodeQL

Virtual call in constructor or destructor

Avoid virtual calls in a constructor or destructor.
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
64.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Serialization of Tags is not working correctly

2 participants